[TypeInfo] Add ArrayShapeType::$sealed
#59981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As 7.3 has been released yet, I think that 8.2 low-deps failures can be ignored. |
GromNaN
reviewed
Mar 15, 2025
62a0dab to
1e70c86
Compare
GromNaN
reviewed
Mar 16, 2025
1e70c86 to
9030a26
Compare
GromNaN
approved these changes
Mar 16, 2025
stof
reviewed
Mar 17, 2025
src/Symfony/Component/TypeInfo/Tests/TypeResolver/StringTypeResolverTest.php
Show resolved
Hide resolved
9030a26 to
0bd93a0
Compare
GromNaN
approved these changes
Mar 18, 2025
fabpot
reviewed
Mar 21, 2025
| @@ -56,6 +60,14 @@ public function __construct(array $shape) | |||
| ksort($sortedShape); | |||
|
|
|||
| $this->shape = $sortedShape; | |||
|
|
|||
| if ($this->extraKeyType xor $this->extraValueType) { | |||
| throw new InvalidArgumentException(\sprintf('You must provide as value for "$%s" when "$%s" is provided.', ...($this->extraKeyType ? ['extraValueType', 'extraKeyType'] : ['extraKeyType', 'extraValueType']))); | |||
There was a problem hiding this comment.
I don't understand this error message.
stof
reviewed
Mar 21, 2025
| @@ -56,6 +60,14 @@ public function __construct(array $shape) | |||
| ksort($sortedShape); | |||
|
|
|||
| $this->shape = $sortedShape; | |||
|
|
|||
| if ($this->extraKeyType xor $this->extraValueType) { | |||
| throw new InvalidArgumentException(\sprintf('You must provide as value for "$%s" when "$%s" is provided.', ...($this->extraKeyType ? ['extraValueType', 'extraKeyType'] : ['extraKeyType', 'extraValueType']))); | |||
There was a problem hiding this comment.
Suggested change
| throw new InvalidArgumentException(\sprintf('You must provide as value for "$%s" when "$%s" is provided.', ...($this->extraKeyType ? ['extraValueType', 'extraKeyType'] : ['extraKeyType', 'extraValueType']))); | |
| throw new InvalidArgumentException(\sprintf('You must provide a value for "$%s" when "$%s" is provided.', $this->extraKeyType ? 'extraValueType' : 'extraKeyType', $this->extraKeyType ? 'extraKeyType' : 'extraValueType')); |
fabpot
approved these changes
Mar 26, 2025
0bd93a0 to
fded1eb
Compare
|
Thank you @mtarld. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement sealed syntax for array shape type, as suggested in #59827 (comment).