Skip to content

[Form] Add input with string value in MoneyType #59993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2025
Merged

[Form] Add input with string value in MoneyType #59993

merged 1 commit into from
Mar 21, 2025

Conversation

StevenRenaux
Copy link
Contributor

@StevenRenaux StevenRenaux commented Mar 17, 2025 •
edited by xabbuh
Loading

Q A
Branch? 7.3
Bug fix? no
New feature? yes
Deprecations? no
Issues Fix #59710
License MIT
Doc PR #20768

Related to the issue, add the possibility to configure the property input with the value string to avoid some unnecessary update with Doctrine.

@carsonbot carsonbot added this to the 7.2 milestone Mar 17, 2025
@StevenRenaux StevenRenaux force-pushed the features/Allow-string-input-for-MoneyType branch from 99fa4f2 to dcd501c Compare March 17, 2025 12:41
@StevenRenaux StevenRenaux mentioned this pull request Mar 17, 2025
Merged
@StevenRenaux StevenRenaux changed the title Add input with string value in MoneyType [Form] Add input with string value in MoneyType Mar 17, 2025
@xabbuh xabbuh changed the base branch from 7.2 to 7.3 March 18, 2025 07:43
@xabbuh xabbuh modified the milestones: 7.2, 7.3 Mar 18, 2025
@xabbuh xabbuh removed the Bug label Mar 18, 2025
@carsonbot carsonbot changed the title [Form] Add input with string value in MoneyType Add input with string value in MoneyType Mar 18, 2025
@xabbuh xabbuh added the Form label Mar 18, 2025
@carsonbot carsonbot changed the title Add input with string value in MoneyType [Form] Add input with string value in MoneyType Mar 18, 2025
@StevenRenaux StevenRenaux force-pushed the features/Allow-string-input-for-MoneyType branch 2 times, most recently from 190e1aa to 5ab085d Compare March 19, 2025 09:21
@StevenRenaux StevenRenaux requested a review from xabbuh March 19, 2025 09:29
@StevenRenaux StevenRenaux force-pushed the features/Allow-string-input-for-MoneyType branch from 5ab085d to 612024e Compare March 20, 2025 16:09
xabbuh
xabbuh approved these changes Mar 20, 2025
View reviewed changes
Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good. Just a minor suggestion for rewording the changelog message.

@StevenRenaux StevenRenaux force-pushed the features/Allow-string-input-for-MoneyType branch from 612024e to b5d6bf8 Compare March 21, 2025 08:13
@fabpot
Copy link
Member

fabpot commented Mar 21, 2025

Thank you @StevenRenaux.

@fabpot fabpot merged commit 272c580 into symfony:7.3 Mar 21, 2025
10 of 11 checks passed
OskarStark added a commit to symfony/symfony-docs that referenced this pull request Apr 7, 2025
@OskarStark
feature #20768 [Form] Update input option for MoneyType (StevenRe…
f70f43d 
…naux)

This PR was merged into the 7.3 branch.

Discussion
----------

[Form] Update `input` option for `MoneyType`

Related to symfony/symfony#59993

Commits
-------

be54b38 Update input option for MoneyType
@fabpot fabpot mentioned this pull request May 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@xabbuh xabbuh xabbuh approved these changes

@yceruto yceruto yceruto approved these changes

Assignees
No one assigned
Labels
Feature Form Status: Reviewed
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.

[Form] MoneyType: allow "string" as input
5 participants
@StevenRenaux @fabpot @xabbuh @yceruto @carsonbot