Skip to content

[FrameworkBundle] fix compatibility with DependencyInjection < 7.3 #59999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2025
Merged

[FrameworkBundle] fix compatibility with DependencyInjection < 7.3 #59999

merged 1 commit into from
Mar 21, 2025

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Mar 18, 2025

Q A
Branch? 7.3
Bug fix? yes
New feature? no
Deprecations? no
Issues
License MIT

@carsonbot carsonbot added this to the 7.3 milestone Mar 18, 2025
@TimWolla TimWolla mentioned this pull request Mar 18, 2025
Merged
@GromNaN
Copy link
Member

GromNaN commented Mar 18, 2025

Increasing the minimum version would be fine and avoid this compatibility code that we will have to remove later. 32c994c

@GromNaN GromNaN mentioned this pull request Mar 18, 2025
Closed
@xabbuh
Copy link
Member Author

xabbuh commented Mar 20, 2025

Status: Needs Review

@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit fd38014 into symfony:7.3 Mar 21, 2025
11 checks passed
@xabbuh xabbuh deleted the pr-59987 branch March 22, 2025 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@GromNaN GromNaN GromNaN requested changes

@alexandre-daubois alexandre-daubois alexandre-daubois approved these changes

Assignees
No one assigned
Labels
Bug FrameworkBundle Status: Needs Review
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.
5 participants
@xabbuh @GromNaN @nicolas-grekas @alexandre-daubois @carsonbot