[Translation] remove deprecated libxml_disable_entity_loader function #60022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, maybe it's better not to change it until the function is removed. But it generate a lot of deprecation warnings. |
|
I guess you have libxml < 2.9? You should upgrade I suppose. Let me close here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this function is deprecated since PHP 8.0.0: https://www.php.net/manual/en/function.libxml-disable-entity-loader.php
At the moment, I just comment the unused function
shouldEnableEntityLoaderbut before finalize this PR, I need your comment about this. There are no replacement forlibxml_disable_entity_loaderPHP function. Have you any idea to replace it or we don't need this for PHP 8.2 ?Thanks.
I see another PR for this in Sf4: https://github.com/symfony/symfony/pull/37790/files
TODO