[Serializer] Fix code skipped by premature return #60025

HypeMC · 2025-03-23T16:53:31Z

The problem with the current code is the early return:

Lines 2007 to 2009 in c9ed762

    
           if (!$container->hasDefinition('serializer.normalizer.object')) { 
        
               return; 
        
           }

Some code after the return is not related to the object normalizer, and should therefor not be skipped:

Lines 2025 to 2026 in c9ed762

    
               $container->getDefinition('serializer.normalizer.property')->setArgument(5, $defaultContext); 
        
           }

This PR replaces the early return by wrapping the code related to the object normalizer inside the if block to prevent any future mistakes.

Probably easier to review with whitespace changes hidden.

nicolas-grekas · 2025-03-24T09:00:08Z

Thank you @HypeMC.

[Serializer] Fix code skipped by premature return

1aec1b3

carsonbot added Status: Needs Review Bug Serializer labels Mar 23, 2025

carsonbot added this to the 6.4 milestone Mar 23, 2025

mtarld approved these changes Mar 24, 2025

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels Mar 24, 2025

nicolas-grekas merged commit 8b43964 into symfony:6.4 Mar 24, 2025
10 of 11 checks passed

HypeMC deleted the fix-code-skipped-by-premature-return branch March 24, 2025 09:01

Provide feedback

	if (!$container->hasDefinition('serializer.normalizer.object')) {
	return;
	}

	$container->getDefinition('serializer.normalizer.property')->setArgument(5, $defaultContext);
	}