Skip to content

[Cache][DoctrineBridge][HttpFoundation][Lock][Messenger] use Table::addPrimaryKeyConstraint() with Doctrine DBAL 4.3+ #60030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2025
Merged

[Cache][DoctrineBridge][HttpFoundation][Lock][Messenger] use Table::addPrimaryKeyConstraint() with Doctrine DBAL 4.3+ #60030

merged 1 commit into from
Mar 26, 2025

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Mar 24, 2025

Q A
Branch? 7.2
Bug fix? yes
New feature? no
Deprecations? no
Issues
License MIT

@carsonbot carsonbot added this to the 7.2 milestone Mar 24, 2025
@xabbuh
Copy link
Member Author

xabbuh commented Mar 24, 2025

Status: Needs work

@xabbuh xabbuh changed the title use Table::addPrimaryKeyConstraint() with Doctrine DBAL 4.3+ [Messenger] use Table::addPrimaryKeyConstraint() with Doctrine DBAL 4.3+ Mar 24, 2025
@xabbuh xabbuh force-pushed the doctrine-dbal-6867 branch from b637f2f to 3c4c158 Compare March 24, 2025 16:33
@xabbuh xabbuh requested a review from chalasr as a code owner March 24, 2025 16:33
@carsonbot carsonbot changed the title [Messenger] use Table::addPrimaryKeyConstraint() with Doctrine DBAL 4.3+ use Table::addPrimaryKeyConstraint() with Doctrine DBAL 4.3+ Mar 24, 2025
@xabbuh xabbuh changed the title use Table::addPrimaryKeyConstraint() with Doctrine DBAL 4.3+ [DoctrineBridge][Messenger] use Table::addPrimaryKeyConstraint() with Doctrine DBAL 4.3+ Mar 24, 2025
stof
stof reviewed Mar 24, 2025
View reviewed changes
Copy link
Member

@stof stof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the Cache and Lock component, and the session storage in HttpFoundation

@xabbuh xabbuh force-pushed the doctrine-dbal-6867 branch from 3c4c158 to 8d71cb3 Compare March 24, 2025 16:58
@xabbuh xabbuh changed the title [DoctrineBridge][Messenger] use Table::addPrimaryKeyConstraint() with Doctrine DBAL 4.3+ [DoctrineBridge][HttpFoundation][Messenger] use Table::addPrimaryKeyConstraint() with Doctrine DBAL 4.3+ Mar 24, 2025
@xabbuh xabbuh force-pushed the doctrine-dbal-6867 branch from 8d71cb3 to bf42190 Compare March 24, 2025 17:00
@xabbuh xabbuh requested a review from jderusse as a code owner March 24, 2025 17:00
@xabbuh xabbuh force-pushed the doctrine-dbal-6867 branch from bf42190 to ed17fb3 Compare March 24, 2025 17:03
@xabbuh xabbuh changed the title [DoctrineBridge][HttpFoundation][Messenger] use Table::addPrimaryKeyConstraint() with Doctrine DBAL 4.3+ [Cache][DoctrineBridge][HttpFoundation][Lock][Messenger] use Table::addPrimaryKeyConstraint() with Doctrine DBAL 4.3+ Mar 24, 2025
@OskarStark OskarStark changed the title [Cache][DoctrineBridge][HttpFoundation][Lock][Messenger] use Table::addPrimaryKeyConstraint() with Doctrine DBAL 4.3+ [Cache][DoctrineBridge][HttpFoundation][Lock][Messenger] use Table::addPrimaryKeyConstraint() with Doctrine DBAL 4.3+ Mar 24, 2025
@xabbuh
Copy link
Member Author

xabbuh commented Mar 24, 2025

Status: Needs review

@carsonbot carsonbot changed the title [Cache][DoctrineBridge][HttpFoundation][Lock][Messenger] use Table::addPrimaryKeyConstraint() with Doctrine DBAL 4.3+ [Cache][DoctrineBridge][HttpFoundation][Lock][Messenger] use Table::addPrimaryKeyConstraint() with Doctrine DBAL 4.3+ Mar 24, 2025
@alexandre-daubois
Copy link
Member

I think you missed EntityTypeTest and UniqueEntityValidatorTest? The deprecation is still raised in these cases

@xabbuh
Copy link
Member Author

xabbuh commented Mar 24, 2025

@alexandre-daubois The remaining deprecations triggered by the DoctrineBridge tests should be solved with doctrine/orm#11882.

nicolas-grekas
nicolas-grekas approved these changes Mar 25, 2025
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange move from the orm, DX wise, isn't it?

@xabbuh xabbuh force-pushed the doctrine-dbal-6867 branch from ed17fb3 to b00b416 Compare March 25, 2025 15:54
@xabbuh
Copy link
Member Author

xabbuh commented Mar 25, 2025

everything is green again \o/

@fabpot
Copy link
Member

fabpot commented Mar 26, 2025

Thank you @xabbuh.

@fabpot fabpot merged commit 2f6b2e6 into symfony:7.2 Mar 26, 2025
9 of 11 checks passed
@xabbuh xabbuh deleted the doctrine-dbal-6867 branch March 26, 2025 08:03
@fabpot fabpot mentioned this pull request Mar 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@alexandre-daubois alexandre-daubois alexandre-daubois approved these changes

@mtarld mtarld mtarld approved these changes

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

@jderusse jderusse Awaiting requested review from jderusse jderusse is a code owner

Assignees
No one assigned
Labels
Bug Cache DoctrineBridge HttpFoundation Lock Messenger Status: Reviewed
Projects
None yet
Milestone
7.2
Development

Successfully merging this pull request may close these issues.
7 participants
@xabbuh @alexandre-daubois @fabpot @nicolas-grekas @stof @mtarld @carsonbot