Skip to content

[Console] Table counts wrong number of padding symbols in renderCell() method when cell contain unicode variant selector #60042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 6.4
Choose a base branch
from
+33 −1
Open

[Console] Table counts wrong number of padding symbols in renderCell() method when cell contain unicode variant selector #60042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc8f7a0
issues/60038: Table counts wrong number of padding symbols in method …
vladimir-vv Mar 26, 2025
61b01a8
issues/60038: Table counts wrong number of padding symbols in method …
vladimir-vv Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Symfony/Component/Console/Helper/Table.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,7 +565,7 @@ private function renderCell(array $row, int $column, string $cellFormat): string

// str_pad won't work properly with multi-byte strings, we need to fix the padding
if (false !== $encoding = mb_detect_encoding($cell, null, true)) {
$width += \strlen($cell) - mb_strwidth($cell, $encoding);
$width += \strlen($cell) - mb_strwidth($cell, $encoding) + substr_count($cell, "\xef\xb8\x8f") + substr_count($cell, "\xef\xb8\x8e");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What exactly does the unicode sequence \xef\xb8\x8e refer to?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These U+FE0F, U+FE0E selectors are used to display emoji with color or monochrome. As I can see usually the U+FE0E selector is skipped.
Example with snowflake:
U+2744 ❄ e2 9d 84
U+2744 ❄ e2 9d 84 ef b8 8e
U+2744 ❄️ e2 9d 84 ef b8 8f

}

$style = $this->getColumnStyle($column);
Expand Down
32 changes: 32 additions & 0 deletions src/Symfony/Component/Console/Tests/Helper/TableTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2078,4 +2078,36 @@ public function testGithubIssue52101HorizontalFalse()
$this->getOutputContent($output)
);
}

public function testGithubIssue60038WidthOfCellWithEmoji()
{
$table = (new Table($output = $this->getOutputStream()))
->setHeaderTitle('Test Title')
->setHeaders(['Title', 'Author'])
->setRows([
["🎭 💫 ☯"." Divine Comedy", "Dante Alighieri"],
// the snowflake (e2 9d 84 ef b8 8f) has a variant selector
["👑 ❄️ 🗡"." Game of Thrones", "George R.R. Martin"],
// the snowflake in text style (e2 9d 84 ef b8 8e) has a variant selector
["❄︎❄︎❄︎ snowflake in text style ❄︎❄︎❄︎", ""],
["And a very long line to show difference in previous lines", ""],
])
;
$table->render();

$this->assertSame(<<<TABLE
+---------------------------------- Test Title -------------+--------------------+
| Title | Author |
+-----------------------------------------------------------+--------------------+
| 🎭 💫 ☯ Divine Comedy | Dante Alighieri |
| 👑 ❄️ 🗡 Game of Thrones | George R.R. Martin |
| ❄︎❄︎❄︎ snowflake in text style ❄︎❄︎❄︎ | |
| And a very long line to show difference in previous lines | |
+-----------------------------------------------------------+--------------------+

TABLE
,
$this->getOutputContent($output)
);
}
}
Loading