[Form] Use duplicate_preferred_choices to set value of ChoiceType #60054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thanks for your PR. You are targeting branch "7.3" but it seems your PR description refers to branch "6.4". Cheers! Carsonbot |
|
Thank you, @carsonbot |
|
it would be great to add a test covering this case (we have tests for the rendering of forms) |
When the preferred choices are not duplicated an option has to be selected in the group of preferred choices. Closes symfony#58561
|
@stof I added tests for both cases, with duplication on and off, to make sure my changes don't break anything. |
stof
approved these changes
Mar 28, 2025
fabpot
approved these changes
Mar 28, 2025
|
Thank you @aleho. |
|
To fix the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the preferred choices are not duplicated an option has to be selected in the group of preferred choices.
Closes #58561
When the preferred choices are not duplicated an option has to be selected in the group of preferred choices.