[Messenger] Exclude AsMessenger attribute from services WIP #60082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just took a look of this PR; Awesome! I learn from what NG coded here. Glad this idea went real, even if it's small ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I wanted to auto exclude from services some classes based on their attributes (like messenger messages or doctrine entities), in order to simplify default config/services.yaml->services. App/.exclude configuration, and after some discussions with Sir Grekas, it seems that it can be achieved directly from the components' repositories, and by tagging the given attributes to the container's config.
I'm a bit stuck here, as:
Any advice or tips would be appreciated to finish this! Sorry for my maybe naive questions