[TypeInfo] add TypeFactoryTrait::arrayKey() #60087
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f9308fe to
8b4d5a2
Compare
mtarld
approved these changes
Mar 30, 2025
| @@ -5,7 +5,7 @@ CHANGELOG | |||
| --- | |||
|
|
|||
| * Add `Type::accepts()` method | |||
| * Add `TypeFactoryTrait::fromValue()` method | |||
| * Add the `TypeFactoryTrait::fromValue()`, `TypeFactoryTrait::arrayShape()`, and `TypeFactoryTrait::arrayKey()` methods | |||
There was a problem hiding this comment.
Maybe we can merge the accepts method as well?
There was a problem hiding this comment.
accepts() was documented for Type as it's not in the trait. Does that really make sense to merge them or isn't it more readable this way?
There was a problem hiding this comment.
These methods are most likely to be accessed via the Type class. But we can keep them separate in the changelog.
OskarStark
approved these changes
Mar 30, 2025
GromNaN
approved these changes
Mar 30, 2025
alexandre-daubois
approved these changes
Mar 31, 2025
|
Thank you @xabbuh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reading the latest PRs about array shapes I wondered if it wouldn't be useful to have a dedicated method for the array key types supported by PHP