Skip to content

[Serializer] Fix PropertyNormalizer with named serializers #60091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

HypeMC
Copy link
Contributor

@HypeMC HypeMC commented Mar 30, 2025

Q A
Branch? 7.2
Bug fix? yes
New feature? no
Deprecations? no
Issues -
License MIT

An alternative approach to #59627. The main issue is that serializer.normalizer.property isn't tagged with serializer.normalizer, which, to my understanding, was intentional. Since MimeMessageNormalizer depends on it, the same instance of PropertyNormalizer (with the default named converter) is used for every named serializer.

This PR checks the arguments of normalizers and registers a child definition for any argument that is an instance of NormalizerInterface and doesn't have the serializer.normalizer tag.

cc @ruudk

@HypeMC HypeMC force-pushed the fix-mime-message-normalizer branch from f9a9efd to d042e1d Compare March 30, 2025 16:35
@HypeMC HypeMC closed this Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants