[FrameworkBundle][RateLimiter] default lock_factory to auto
#60099
+34
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
approved these changes
Apr 2, 2025
yceruto
approved these changes
Apr 2, 2025
fabpot
approved these changes
Apr 3, 2025
|
Thank you @kbond. |
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Apr 7, 2025
This PR was merged into the 7.3 branch. Discussion ---------- [RateLimiter] default `lock_factory` to `auto` Ref: symfony/symfony#60099 Closes #20854. This is a small DX improvement so don't think it needs too much explanation. Commits ------- eb5f908 [RateLimiter] default `lock_factory` to `auto`
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when configuring a rate limiter and using the default configured lock factory (
lock.factory), it fails ifsymfony/lockisn't installed. You have to explicitly set it tonullif you want to configure rate limiters without the lock component.This changes the default
lock_factorytoautothen, at compile time, sets it tolock.factoryifsymfony/lockis installed andnullif not.