-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[HttpFoundation] Add UriSigner::verify()
that throws named exceptions
#60102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UriSigner::signAndWrap(): SignedUri
and UriSigner::verify(): SignedUri
UriSigner::signAndWrap(): SignedUri
and UriSigner::verify(): SignedUri
UriSigner::signAndWrap(): SignedUri
and UriSigner::verify(): SignedUri
UriSigner::signAndWrap(): SignedUri
and UriSigner::verify(): SignedUri
UriSigner::signAndWrap(): SignedUri
and UriSigner::verify(): SignedUri
UriSigner::signAndWrap()
and UriSigner::verify()
I'm not a huge fan of |
ee8c09d
to
a627d43
Compare
UriSigner::signAndWrap()
and UriSigner::verify()
UriSigner::verify()
that throws named exceptions
I've updated this PR to just add |
weaverryan
reviewed
Apr 2, 2025
src/Symfony/Component/HttpFoundation/Exception/UnverifiedSignedUriException.php
Show resolved
Hide resolved
src/Symfony/Component/HttpFoundation/Exception/UnSignedUriException.php
Outdated
Show resolved
Hide resolved
9a617d0
to
0a35de0
Compare
nicolas-grekas
approved these changes
Apr 16, 2025
(rebase needed) |
493f298
to
60b8ba7
Compare
src/Symfony/Component/HttpFoundation/Exception/SignedUriException.php
Outdated
Show resolved
Hide resolved
ce0feb3
to
ac4de2c
Compare
Thank you @kbond. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
UriSigner::verify()
: Similar tocheck()
but throwsUnSignedUriException
,UnverifiedSignedUriException
orExpiredSignedUriException
if invalid (no return if valid).Usage example:
TODO