make method signature compatible with PHP 8.5 #60134
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is probably related to php/php-src#17755, but traits were supposed to be excluded to keep resolving I suggest reporting that as a bug to PHP. |
|
/cc @Girgias FYI (until the issue is open on php-src). Closing as we shouldn't do this change of course. |
|
Ah, yeah this is a bug. I'll have a look but please do open an issue on php-src as I will forget otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://3v4l.org/6J3Q9/rfc#vgit.master (PHP 8.5) vs. https://3v4l.org/6J3Q9#v8.4.5 (before)
I did not find the commit in the PHP source code causing this behaviour so I am not sure if it's intended or indicating a bug in PHP.