Skip to content

[Config] ResourceCheckerConfigCache metadata unserialize emits warning #60137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025

Conversation

elcmichou
Copy link

Q A
Branch? 7.2
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #59196
License MIT

Description

This PR fixes the warning unserialize(): Function spl_autoload_call() hasn't defined the class it was called for that occurs when unserializing metadata in the ResourceCheckerConfigCache when unserialize_callback_func is set to spl_autoload_call.

The fix adds the allowed_classes => false parameter to the unserialize() call, preventing PHP from attempting to reconstruct objects of unknown classes, which eliminates the warnings while maintaining the intended functionality.

Test case

The issue can be reproduced by:

  1. Adding ini_set('unserialize_callback_func', 'spl_autoload_call'); at the beginning of a Symfony application (e.g., in bin/console)
  2. Running bin/console cache:clear
  3. Observing the warnings about classes that couldn't be found

With this change, the warnings no longer appear while the cache continues to function correctly.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot carsonbot changed the title bug #59196 [Config] ResourceCheckerConfigCache metadata unserialize e… [Config] bug #59196 ResourceCheckerConfigCache metadata unserialize e… Apr 3, 2025
@nicolas-grekas nicolas-grekas changed the title [Config] bug #59196 ResourceCheckerConfigCache metadata unserialize e… [Config] ResourceCheckerConfigCache metadata unserialize emits warning Apr 3, 2025
@fabpot
Copy link
Member

fabpot commented Apr 4, 2025

Thank you @elcmichou.

@fabpot fabpot merged commit e10963f into symfony:7.2 Apr 4, 2025
9 of 11 checks passed
@fabpot fabpot mentioned this pull request May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants