Skip to content

[String] Fix snake function #60147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[String] Fix snake function #60147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions src/Symfony/Component/String/AbstractUnicodeString.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,10 +346,19 @@ public function reverse(): static

public function snake(): static
{
$str = $this->camel();
$str->string = mb_strtolower(preg_replace(['/(\p{Lu}+)(\p{Lu}\p{Ll})/u', '/([\p{Ll}0-9])(\p{Lu})/u'], '\1_\2', $str->string), 'UTF-8');
$str = clone $this;

return $str;
// space numbers
$str->string = preg_replace('/\d+/u', ' $0 ', $str->string);
// split words
$str->string = preg_replace(['/(\p{Lu}+)(\p{Lu}\p{Ll})/u', '/([\p{Ll}0-9])(\p{Lu})/u'], '\1 \2', $str->string);
// clean spaces
$str->string = preg_replace(['/[^\pL0-9]++/u', '/( {2,})/u'], ' ', $str->string);

return $str->trimStart()
->trimEnd()
->replace(' ', '_')
->lower();
}

public function title(bool $allWords = false): static
Expand Down
16 changes: 13 additions & 3 deletions src/Symfony/Component/String/ByteString.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,10 +342,20 @@ public function slice(int $start = 0, ?int $length = null): static

public function snake(): static
{
$str = $this->camel();
$str->string = strtolower(preg_replace(['/([A-Z]+)([A-Z][a-z])/', '/([a-z\d])([A-Z])/'], '\1_\2', $str->string));
$str = clone $this;

return $str;
$str->string = preg_replace('/[^a-zA-Z0-9\x7f-\xff]++/', ' ', $str->string);
// space numbers
$str->string = preg_replace('/(\d+)/', ' $1 ', $str->string);
// split words
$str->string = preg_replace(['/([A-Z]+)([A-Z][a-z])/', '/([a-z\d])([A-Z])/'], '\1 \2', $str->string);
// clean spaces
$str->string = preg_replace('/( {2,})/', ' ', $str->string);

return $str->trimStart()
->trimEnd()
->replace(' ', '_')
->lower();
}

public function splice(string $replacement, int $start = 0, ?int $length = null): static
Expand Down
19 changes: 12 additions & 7 deletions src/Symfony/Component/String/Tests/AbstractAsciiTestCase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1071,19 +1071,24 @@ public static function provideSnake()
['symfony_is_great', 'symfony-is-great'],
['symfony_is_great', 'symfony.is.great'],
['symfony_is_great', 'symfonyIsGreat'],
['symfony5_is_great', 'symfony5IsGreat'],
['symfony5is_great', 'symfony5isGreat'],
['symfony_5_is_great', 'symfony5IsGreat'],
['symfony_5_is_great', 'symfony5isGreat'],
['symfony_is_great', 'Symfony is great'],
['symfony_is_a_great_framework', 'symfonyIsAGreatFramework'],
['symfony_is_great', 'symfonyIsGREAT'],
['symfony_is_great', 'SYMFONY IS GREAT'],
['symfony_7_is_great', 'symfony 7 is great'],
['symfony_7_4_is_great', 'symfony 7.4 is great'],
['symfony_2000_is_great', 'symfony 2000 is great'],
['symfony_is_really_great', 'symfonyIsREALLYGreat'],
['symfony', 'SYMFONY'],
['symfonyisgreat', 'SYMFONY IS GREAT'],
['symfonyisgreat', 'SYMFONY_IS_GREAT'],
['symfony_is_great', 'SYMFONY IS GREAT'],
['symfony_is_great', 'SYMFONY_IS_GREAT'],
['symfony_is_great', 'symfony is great'],
['symfonyisgreat', 'SYMFONY IS GREAT'],
['symfonyisgreat', 'SYMFONY _ IS _ GREAT'],
['symfony_isgreat', 'Symfony IS GREAT!'],
['symfony_is_great', 'SYMFONY IS GREAT'],
['symfony_is_great', 'SYMFONY _ IS _ GREAT'],
['symfony_is_great', 'Symfony IS GREAT!'],
['best_symfony_is_2', 'Best Symfony is 2'],
['123_customer_with_special_name', '123-customer,with/special#name'],
];
}
Expand Down
Loading