Skip to content

[Notifier] let the data provider key match the test method argument names #60150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2025

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Apr 4, 2025

Q A
Branch? 7.3
Bug fix? no
New feature? no
Deprecations? no
Issues
License MIT

@xabbuh xabbuh requested a review from OskarStark as a code owner April 4, 2025 13:15
@carsonbot carsonbot added this to the 7.3 milestone Apr 4, 2025
@carsonbot carsonbot changed the title [Notifier] let the data provider key match the test method argument names [Notifier] let the data provider key match the test method argument names Apr 4, 2025
@xabbuh
Copy link
Member Author

xabbuh commented Apr 4, 2025

the keys returned by the data provider now match the argument names of the test method:

public function testWithEmbed(BlueskyOptions $blueskyOptions, string $expectedJsonResponse)

@fabpot
Copy link
Member

fabpot commented Apr 6, 2025

Thank you @xabbuh.

@fabpot fabpot merged commit 1d2d181 into symfony:7.3 Apr 6, 2025
9 of 11 checks passed
@xabbuh xabbuh deleted the pr-59667 branch April 6, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants