[TwigBridge] Allow attachment name to be set for inline images #60163
+115
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nicolas-grekas I could write a test case for |
|
The proposal looks good to me. I'd say it just misses some tests + a line in the CHANGELOG file of the bridge. |
f7281a8 to
eda234a
Compare
|
@nicolas-grekas I'm not too happy with hard-coding the strings to test like that because of how line breaks are handled, but I guess the intention is clear and they should be easy to maintain if something changes. The Doctrine tests failing are hopefully not related to my changes? |
|
Thank you @aleho. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a recommended setup attaching images from Twig would normally result in attachment names like
@assets/img/file.pngwhich might not be a good file name to expose to email clients. This allows the name to be specified, analogous toattachin the same wrapper.