[Cache] Fix proxying third party PSR-6 cache items #60167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… should work with adapter of CacheItemPoolInterface other than \Symfony\Component\Cache\Adapter\AdapterInterface
|
I could be missing something, but the fail looks totally unrelated to the one-line-change I made 🤔 |
|
this change is legitimate, but it also indicates a gap in test coverage for our ProxyAdapter. The whole point of the ProxyAdapter is to adapt external PSR-6 implementations, but the tests of that class are adapting our own ArrayAdapter (and so won't detect cases where the implementation fails for third-party implementations). |
stof
approved these changes
Apr 7, 2025
|
Thank you @PatchRanger. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...work with adapter of CacheItemPoolInterface other than \Symfony\Component\Cache\Adapter\AdapterInterface