Skip to content

[PhpUnitBridge] properly clean up mocked features after tests have run #60174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Apr 8, 2025

Q A
Branch? 7.2
Bug fix? yes
New feature? no
Deprecations? no
Issues
License MIT

If a test has been skipped or if it errored, the mocked PHP functions must be cleaned up as well.

@carsonbot carsonbot added this to the 7.2 milestone Apr 8, 2025
@carsonbot carsonbot changed the title [PhpUnitBridge] properly clean up mocked features after tests have run [PhpUnitBridge] properly clean up mocked features after tests have run Apr 8, 2025
If a test has been skipped or if it errored, the mocked PHP functions
must be cleaned up as well.
@xabbuh xabbuh force-pushed the phpunit-bridge-mock-cleanup branch from 77d6b8a to 9757a69 Compare April 8, 2025 11:56
@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit da62118 into symfony:7.2 Apr 8, 2025
8 of 12 checks passed
@xabbuh xabbuh deleted the phpunit-bridge-mock-cleanup branch April 8, 2025 13:44
@fabpot fabpot mentioned this pull request May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants