[Form] skip test if the installed ICU version is too modern #60177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Apr 8, 2025
| Q | A |
|---|---|
| Branch? | 6.4 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Issues | |
| License | MIT |
|
shouldn't we write the test expectation in a way compatible with the ICU version used on CI to avoid skipping tests all the time in CI ? Otherwise, the test might not bring actual value |
|
Thank you @xabbuh. |
|
@stof I would love to but that would actually require to patch the data transformer. The now failing tests after updating to Ubuntu 24.04 just shows that our data transformer is actually broken since a long time with more recent ICU versions. I have no idea yet how to fix that, but the CI shouldn't fail because of that. |
|
I opened #60178 to track this issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.