-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[DependencyInjection] Add "when" argument to #[AsAlias] #60186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DependencyInjection] Add "when" argument to #[AsAlias] #60186
Conversation
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
32ab3b0
to
e3fcf6d
Compare
Accepting string|array would make sense to me indeed. |
e3fcf6d
to
2020177
Compare
👍 Updated the implem to use a The new tests pass now locally |
src/Symfony/Component/DependencyInjection/Attribute/AsAlias.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Tests/Loader/FileLoaderTest.php
Outdated
Show resolved
Hide resolved
I've checked the failling tests quickly and they seem unrelated 👍 Looks like they're also failling on other PRs |
0f2869f
to
187524d
Compare
Thank you @Zuruuh. |
Also I wonder if it would make sense to accept an array of environments in
#[AsAlias]
, since in practice if I want to use the same service in two envs I'd have to duplicate the whole declaration nowThoughts ?