[TwigBundle] Skip build dir warmup when auto-reload is enabled #60196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This problem is not specific to the TemplateCacheWarmer, so every other Optional CacheWarmer will have the same behavior, which is not so great IMHO. |
|
Not really useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the build dir is different from the cache dir, the twig cache warmer is called 2 times, once during build, and the second during cache warmup. In development, when auto-reload is enabled, warming the cache during the build of the container is not necessary. Skipping will save time in dev.
If #54384 is merged before 7.3, this PR is not necessary.