Skip to content

[Emoji] Add license in each generated files #60202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Apr 12, 2025

Q A
Branch? 6.4
Bug fix? no
New feature? no
Deprecations? no
Issues Fix #60190 (review)
License MIT

@fabpot
Copy link
Member

fabpot commented Apr 12, 2025

I don't think the is needed as these files are generated anyway.

@GromNaN
Copy link
Member

GromNaN commented Apr 13, 2025

If this PR is rejected, fabbot should be updated to not add the license header to the generated files.

@fabpot
Copy link
Member

fabpot commented Apr 13, 2025

If this PR is rejected, fabbot should be updated to not add the license header to the generated files.

That was already the case for files under src/Symfony/Component/Intl/Resources/data/, I've just added src/Symfony/Component/Emoji/Resources/data/ as well now.

@fabpot fabpot closed this Apr 13, 2025
@lyrixx lyrixx deleted the emoji-license branch April 13, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants