Skip to content

[Process] Narrow PhpExecutableFinder return types #60229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2025
Merged

[Process] Narrow PhpExecutableFinder return types #60229

merged 1 commit into from
Apr 17, 2025
+2 −0

Conversation

Slamdunk
Copy link
Contributor

Narrow PhpExecutableFinder return types to the actual ones.

@carsonbot carsonbot added this to the 6.4 milestone Apr 17, 2025
@nicolas-grekas nicolas-grekas modified the milestones: 6.4, 7.3 Apr 17, 2025
nicolas-grekas
nicolas-grekas approved these changes Apr 17, 2025
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for 7.3 since that's not a bugfix.

@nicolas-grekas nicolas-grekas changed the base branch from 6.4 to 7.3 April 17, 2025 09:11
@nicolas-grekas
Copy link
Member

Thank you @Slamdunk.

@nicolas-grekas nicolas-grekas merged commit ed7dba6 into symfony:7.3 Apr 17, 2025
4 of 7 checks passed
@Slamdunk Slamdunk deleted the process_narrow_types branch April 17, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Process Status: Reviewed
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.
3 participants
@Slamdunk @nicolas-grekas @carsonbot