-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Fix ServiceSubscriberTrait
and ServiceMethodsSubscriberTrait
for nullable services
#60265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
StevenRenaux
wants to merge
1
commit into
symfony:7.3
from
StevenRenaux:fix/Fix-nullable-property-for-SubscribedService-attribute
Closed
Fix ServiceSubscriberTrait
and ServiceMethodsSubscriberTrait
for nullable services
#60265
StevenRenaux
wants to merge
1
commit into
symfony:7.3
from
StevenRenaux:fix/Fix-nullable-property-for-SubscribedService-attribute
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neirda24
reviewed
Apr 25, 2025
src/Symfony/Contracts/Tests/Service/ServiceMethodsSubscriberTraitTest.php
Outdated
Show resolved
Hide resolved
78e644c
to
ac3ac74
Compare
Jean-Beru
approved these changes
Apr 25, 2025
fabpot
added a commit
that referenced
this pull request
Apr 30, 2025
…ice (StevenRenaux) This PR was merged into the 6.4 branch. Discussion ---------- [Contracts] Fix `ServiceSubscriberTrait` for nullable service | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | License | MIT Used in a bundle context. If you use the following example, you will get an exception: `ServiceNotFoundException: The service "twig" in the container provided to "App\Service\Dependency" has a dependency on a non-existent service "Twig\Environment".` The `nullable` argument of the `SubscribedService` attribute is ignored. ```php // src/Service/TwigAware.php namespace App\Service; use Twig\Environment; use Symfony\Contracts\Service\Attribute\SubscribedService; trait TwigAware { #[SubscribedService('twig', nullable: true)] private function twig(): Environment { if (!$this->container->has('twig') ) { throw new \LogicException(\sprintf('Twig is required to use "%s" method. Try to run "composer require symfony/twig-bundle".', __METHOD__)); } return $environment; } } // src/Service/MyService.php namespace App\Service; use Symfony\Contracts\Service\ServiceSubscriberInterface; use Symfony\Contracts\Service\ServiceSubscriberTrait; class MyService implements ServiceSubscriberInterface { use ServiceSubscriberTrait, TwigAware; public function doWithTwig(): void { // $this->twig() ... } } ``` Related to #60265 Commits ------- 95b0f9b Fix ServiceMethodsSubscriberTrait for nullable service
fabpot
added a commit
that referenced
this pull request
Apr 30, 2025
…le service (StevenRenaux) This PR was merged into the 7.2 branch. Discussion ---------- [Contracts] Fix `ServiceMethodsSubscriberTrait` for nullable service | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | License | MIT Used in a bundle context. If you use the following example, you will get an exception: `ServiceNotFoundException: The service "twig" in the container provided to "App\Service\Dependency" has a dependency on a non-existent service "Twig\Environment".` The `nullable` argument of the `SubscribedService` attribute is ignored. ```php // src/Service/TwigAware.php namespace App\Service; use Twig\Environment; use Symfony\Contracts\Service\Attribute\SubscribedService; trait TwigAware { #[SubscribedService('twig', nullable: true)] private function twig(): Environment { if (!$this->container->has('twig') ) { throw new \LogicException(\sprintf('Twig is required to use "%s" method. Try to run "composer require symfony/twig-bundle".', __METHOD__)); } return $environment; } } // src/Service/MyService.php namespace App\Service; use Symfony\Contracts\Service\ServiceSubscriberInterface; use Symfony\Contracts\Service\ServiceSubscriberTrait; class MyService implements ServiceSubscriberInterface { use ServiceSubscriberTrait, TwigAware; public function doWithTwig(): void { // $this->twig() ... } } ``` Related to #60265 Commits ------- e67db9a Fix ServiceMethodsSubscriberTrait for nullable service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used in a bundle context.
If you use the following example, you will get an exception:
ServiceNotFoundException: The service "twig" in the container provided to "App\Service\Dependency" has a dependency on a non-existent service "Twig\Environment".
The
nullable
argument of theSubscribedService
attribute is ignored.