[Validator] [WordCount] Treat 0 as one character word and do not exclude it #60270
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
Failed unit tests seems not related to my changes |
xabbuh
reviewed
Apr 25, 2025
src/Symfony/Component/Validator/Constraints/WordCountValidator.php
Outdated
Show resolved
Hide resolved
xabbuh
approved these changes
Apr 25, 2025
OskarStark
approved these changes
Apr 25, 2025
fabpot
approved these changes
Apr 27, 2025
a801daa to
6fded36
Compare
|
Thank you @sidz. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New WordCount validator has been introduced in the Symfony 7.2 but it has an issue and treats sentence ended on zero (0) as contains an empty string.
This PR adds a callback function into
array_filterto fix the issue.