[HttpFoundation] Encode path in X-Accel-Redirect header
#60292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
35cfd61 to
4c06562
Compare
X-AccelRedirect header
OskarStark
reviewed
Apr 28, 2025
src/Symfony/Component/HttpFoundation/Tests/BinaryFileResponseTest.php
Outdated
Show resolved
Hide resolved
OskarStark
reviewed
Apr 28, 2025
4c06562 to
f156214
Compare
X-AccelRedirect headerX-Accel-Redirect header
f156214 to
e4c1906
Compare
OskarStark
reviewed
May 5, 2025
src/Symfony/Component/HttpFoundation/Tests/BinaryFileResponseTest.php
Outdated
Show resolved
Hide resolved
e4c1906 to
a74684e
Compare
OskarStark
reviewed
May 6, 2025
src/Symfony/Component/HttpFoundation/Tests/BinaryFileResponseTest.php
Outdated
Show resolved
Hide resolved
a74684e to
416e814
Compare
src/Symfony/Component/HttpFoundation/Tests/BinaryFileResponseTest.php
Outdated
Show resolved
Hide resolved
we need to encode the path in X-Accel-Redirect header, otherwise nginx fail when certain characters are present in it (like % or ?) rack/rack#1306
416e814 to
bcf20bc
Compare
X-Accel-Redirect headerX-Accel-Redirect header
nicolas-grekas
approved these changes
May 11, 2025
fabpot
approved these changes
May 12, 2025
|
Thank you @Athorcis. |
This was referenced May 25, 2025
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The path in
X-Accel-Redirectheader needs to be encoded otherwise nginx fail when certain characters are present in it (like % or ?)