[HttpClient] do not lose response information when truncating the debug buffer #60295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Apr 28, 2025
| Q | A |
|---|---|
| Branch? | 7.3 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Issues | |
| License | MIT |
xabbuh
commented
Apr 28, 2025
| @@ -221,6 +220,7 @@ public function getInfo(?string $type = null): mixed | |||
| rewind($this->debugBuffer); | |||
| ftruncate($this->debugBuffer, 0); | |||
| } | |||
| $this->info = array_merge($this->info, $info); | |||
There was a problem hiding this comment.
Before #60241 getInfo() could have been called multiple times but the debug info would always be present as the debug buffer was never truncated and thus preserved for subsequent calls. This is no longer the case as we truncate the buffer two lines above just after reading it. Following calls of getInfo() would this no longer read the debug information from the buffer but we need to store it at some other place.
fabpot
approved these changes
May 2, 2025
|
Thank you @xabbuh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.