[TwigBundle] bump the required Twig bridge version #60304
Merged
+9
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Apr 30, 2025
| Q | A |
|---|---|
| Branch? | 7.3 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Issues | |
| License | MIT |
GromNaN
reviewed
Apr 30, 2025
src/Symfony/Bundle/TwigBundle/DependencyInjection/TwigExtension.php
Outdated
Show resolved
Hide resolved
yceruto
approved these changes
Apr 30, 2025
GromNaN
approved these changes
Apr 30, 2025
xabbuh
commented
Apr 30, 2025
| @@ -43,6 +43,7 @@ public function registerBundles(): iterable | |||
| public function registerContainerConfiguration(LoaderInterface $loader): void | |||
| { | |||
| $loader->load(static function (ContainerBuilder $container) { | |||
| $container->setParameter('kernel.secret', 'secret'); | |||
There was a problem hiding this comment.
The lowest installed Twig version that is now installed is 3.21. This means that this test is not skipped anymore, but since FrameworkBundle 6.4 is installed we also need the kernel.secret parameter to be set as the uri_signer is not lazy (this was changed with #59086 in Symfony 7.2).
fabpot
approved these changes
May 2, 2025
|
Thank you @xabbuh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.