-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Notifier] [Slack] Add SlackPlainTextInputBlock for Slack message #60310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
camilleislasse
wants to merge
4
commits into
symfony:7.4
Choose a base branch
from
camilleislasse:add-slack-plaintext-input-block
base: 7.4
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
52 changes: 52 additions & 0 deletions
52
src/Symfony/Component/Notifier/Bridge/Slack/Block/SlackPlainTextInputBlock.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
<?php | ||
|
||
/* | ||
* This file is part of the Symfony package. | ||
* | ||
* (c) Fabien Potencier <fabien@symfony.com> | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
namespace Symfony\Component\Notifier\Bridge\Slack\Block; | ||
|
||
final class SlackPlainTextInputBlock extends AbstractSlackBlock | ||
{ | ||
private const LABEL_LIMIT = 150; | ||
private const ACTION_ID_LIMIT = 255; | ||
private const PLACEHOLDER_LIMIT = 150; | ||
|
||
public function __construct(string $labelText, string $actionId, ?string $placeholderText = null) | ||
{ | ||
if (\strlen($labelText) > self::LABEL_LIMIT) { | ||
throw new \LengthException(\sprintf('Maximum length for the label text is %d characters.', self::LABEL_LIMIT)); | ||
} | ||
|
||
if (\strlen($actionId) > self::ACTION_ID_LIMIT) { | ||
throw new \LengthException(\sprintf('Maximum length for the action ID is %d characters.', self::ACTION_ID_LIMIT)); | ||
} | ||
|
||
if ($placeholderText && \strlen($placeholderText) > self::PLACEHOLDER_LIMIT) { | ||
throw new \LengthException(\sprintf('Maximum length for the placeholder text is %d characters.', self::PLACEHOLDER_LIMIT)); | ||
} | ||
$this->options = [ | ||
'type' => 'input', | ||
'element' => [ | ||
'type' => 'plain_text_input', | ||
'action_id' => $actionId, | ||
], | ||
'label' => [ | ||
'type' => 'plain_text', | ||
'text' => $labelText, | ||
], | ||
]; | ||
|
||
if ($placeholderText) { | ||
$this->options['element']['placeholder'] = [ | ||
'type' => 'plain_text', | ||
'text' => $placeholderText, | ||
]; | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
|
@@ -242,6 +242,28 @@ $chatMessage->options($options); | |||||||
$chatter->send($chatMessage); | ||||||||
``` | ||||||||
|
||||||||
Adding a Plain Text Input to a Message | ||||||||
---------------------------- | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Please make the underline length match the title |
||||||||
To add a simple text input field to your Slack message, use the `SlackPlainTextInputBlock` class. | ||||||||
```php | ||||||||
use Symfony\Component\Notifier\Bridge\Slack\Block\SlackPlainTextInputBlock; | ||||||||
use Symfony\Component\Notifier\Bridge\Slack\SlackOptions; | ||||||||
use Symfony\Component\Notifier\Message\ChatMessage; | ||||||||
|
||||||||
$chatMessage = new ChatMessage('Enter your feedback'); | ||||||||
|
||||||||
$options = (new SlackOptions()) | ||||||||
->block( | ||||||||
new SlackPlainTextInputBlock('Your Feedback', 'feedback_action_id', 'Type your feedback here...') | ||||||||
); | ||||||||
|
||||||||
// Add the custom options to the chat message and send the message | ||||||||
$chatMessage->options($options); | ||||||||
|
||||||||
$chatter->send($chatMessage); | ||||||||
``` | ||||||||
|
||||||||
|
||||||||
Sending a Message as a Reply | ||||||||
---------------------------- | ||||||||
|
||||||||
|
66 changes: 66 additions & 0 deletions
66
src/Symfony/Component/Notifier/Bridge/Slack/Tests/Block/SlackPlainTextInputBlockTest.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
<?php | ||
|
||
namespace Symfony\Component\Notifier\Bridge\Slack\Tests\Block; | ||
|
||
use PHPUnit\Framework\TestCase; | ||
use Symfony\Component\Notifier\Bridge\Slack\Block\SlackPlainTextInputBlock; | ||
|
||
final class SlackPlainTextInputBlockTest extends TestCase | ||
{ | ||
public function testCanBeInstantiatedWithPlaceholder() | ||
{ | ||
$block = new SlackPlainTextInputBlock('Time spent', 'time_spent_input', 'Enter some text here'); | ||
$this->assertSame([ | ||
'type' => 'input', | ||
'element' => [ | ||
'type' => 'plain_text_input', | ||
'action_id' => 'time_spent_input', | ||
'placeholder' => [ | ||
'type' => 'plain_text', | ||
'text' => 'Enter some text here', | ||
], | ||
], | ||
'label' => [ | ||
'type' => 'plain_text', | ||
'text' => 'Time spent', | ||
], | ||
], $block->toArray()); | ||
} | ||
|
||
public function testCanBeInstantiatedWithoutPlaceholder() | ||
{ | ||
$block = new SlackPlainTextInputBlock('Time spent', 'time_spent_input'); | ||
$this->assertSame([ | ||
'type' => 'input', | ||
'element' => [ | ||
'type' => 'plain_text_input', | ||
'action_id' => 'time_spent_input', | ||
], | ||
'label' => [ | ||
'type' => 'plain_text', | ||
'text' => 'Time spent', | ||
], | ||
], $block->toArray()); | ||
} | ||
|
||
public function testThrowsWhenLabelExceedsCharacterLimit() | ||
{ | ||
$this->expectException(\LengthException::class); | ||
$this->expectExceptionMessage('Maximum length for the label text is 150 characters.'); | ||
new SlackPlainTextInputBlock(str_repeat('a', 151), 'time_spent_input'); | ||
} | ||
|
||
public function testThrowsWhenActionIdExceedsCharacterLimit() | ||
{ | ||
$this->expectException(\LengthException::class); | ||
$this->expectExceptionMessage('Maximum length for the action ID is 255 characters.'); | ||
new SlackPlainTextInputBlock('Time spent', str_repeat('a', 256)); | ||
} | ||
|
||
public function testThrowsWhenPlaceholderExceedsCharacterLimit() | ||
{ | ||
$this->expectException(\LengthException::class); | ||
$this->expectExceptionMessage('Maximum length for the placeholder text is 150 characters.'); | ||
new SlackPlainTextInputBlock('Time spent', 'time_spent_input', str_repeat('a', 151)); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.