[Uid] Unify InvalidUuidException and InvalidUlidException #60328
+8
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we suddenly start to throw a different exception, wouldn't this break existing code that catches the "old" exception? |
|
Hi @derrabus ,
That's a great question. No, it wouldn't break, since it has never been released. That's why I'm opening this PR now, so that these two exceptions won't create backward compatibility promise starting from 7.3 and onward. |
|
Yes, it is not released yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR unifies
InvalidUuidExceptionandInvalidUlidException, created as the part of #60226 .InvalidUidExceptionin itself gives enough context about its origin, and it's possible to determine whence the exception originated from by checking its getFile, or checking the trace.Therefore, it's not necessary to make two exceptions if there can be only one.