[PropertyAccess] Improve PropertyAccessor::setValue param docs #60374
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added param-out for the $objectOrArray argument so static code analysis does not assume the passed object can change type or become an array
nicolas-grekas
approved these changes
May 9, 2025
fabpot
approved these changes
May 9, 2025
|
Thank you @Qronicle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request was made to help static code analyzers understand that when calling
PropertyAccessor::setValue, this will not change the type of the passed$objectOrArray.At the moment static analysis will point out that the value of
$objectOrArraycan be any object or an array after calling thesetValuemethod, which is of course not the case.The solution comes directly from this closed PHPStan issue: phpstan/phpstan#12399
(Other tools like Psalm also support
@param-out)