[DependencyInjection][FrameworkBundle] Fix precedence of App\Kernel alias and ignore container.excluded tag on synthetic services
#60392
+33
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
App\Kernel alias and ignore container.excluded tag on synthetic services
OskarStark
reviewed
May 9, 2025
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Compiler/ResolveInstanceofConditionalsPass.php
Show resolved
Hide resolved
GromNaN
approved these changes
May 9, 2025
5c475e1 to
d8d9e92
Compare
welcoMattic
reviewed
May 9, 2025
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
Outdated
Show resolved
Hide resolved
welcoMattic
approved these changes
May 9, 2025
…lias and ignore container.excluded tag on synthetic services
d8d9e92 to
023c44c
Compare
Merged
|
Hello @nicolas-grekas ,
|
|
@adpeyre I don't know, please provide a reproducer in a new issue if you can (I installed doctrine-bundle with Symfony 7.3 successfully, which means I cannot reproduce). |
|
Note that this error message is not found anywhere in Symfony 7.3 so I'm skeptical. |
|
I think the person in my team hasn't updated their symfony properly to test 7.3.... This appears to be symfony 7.2 code... Sorry Nicolas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autoconfiguration cannot make a service abstract so I'm removing the related calls, they're confusing.
Then, I'm moving the definition of the
App\Kernelalias after loadingservices.yaml, so that the alias overrides the discovered corresponding class.And I make instance-of-conditionals ignore
container.excludedtags on synthetic services. An alternative could be to check if the class implementsKernelInterfacelike proposed in #60191 (comment) but I think the rule I'm proposing here is more generic.