Done

Why this functional test? A simple unit test would be enough to check if it works.

I agree with @Tobion. Functional tests are very slow to run, so whenever we can write unit tests, that's far better.

I think just adding some unit tests to HttpUtilsTest is really enough.

The tests doesn't check functionality of rawurldecode function, the test must check something like "foo%20bar%40baz" for route with path like "foo bar@baz".
The rawurldecode is not about unicode, so the given path is not useful.

Some similar work for line #99 $parameters = $this->urlMatcher->match($request->getPathInfo()); also may be needed

Some similar work for line #99 $parameters = $this->urlMatcher->match($request->getPathInfo()); also may be needed

@empire no, the matcher url decodes itself. The rawurldecode is partly about unicode, because multibyte chars get encoded as octets, too. so the test is useful. but the focus here should indeed more be about those standard encodings like %20.

Thanks @Tobion for your kindly comment.

I don't have a clue what should I do in the unit test, I need any advice for this. In current functional test web client all request and redirects urls like "/%D0%B2%D1%85%D0%BE%D0%B4". May be just add some kind symbol collecton to test.

@omgnull, I think you can test your work with doing something like following asertion in HttpUtilsTests:

$this->assertTrue($utils->checkRequestPath($this->getRequest('/foo%20bar'), '/foo bar'));
$this->assertFalse($utils->checkRequestPath($this->getRequest('/foo%20bar'), '/foo%20bar'));

If my previous comment is correct, following assertion is also needed

// Plus must not decoded to space
$this->assertTrue($utils->checkRequestPath($this->getRequest('/foo+bar'), '/foo+bar')); 

// Checking unicode
$this->assertTrue($utils->checkRequestPath($this->getRequest('/%D0%B2%D1%85%D0%BE%D0%B4'), '/вход'));

In hope this comment will be helpful.

@omgnull Does the hints provided by @empire enough to add some unit tests? Do you need some more help?

@fabpot. yes. I have to find some time. This weekend I think.