[Validator] Add tests for MacAddress
#60422
Open
+25
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Symfony/Component/Validator/Test/ConstraintValidatorTestCase.php
Outdated
Show resolved
Hide resolved
stof
requested changes
May 20, 2025
src/Symfony/Component/Validator/Tests/Constraints/MacAddressValidatorTest.php
Outdated
Show resolved
Hide resolved
MacAddress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add some tests to the MacAddress Validator.
[x] Add testing for empty string and null valuesAlready handled withtestNullIsValidandtestEmptyStringIsValidmethods[x] Add testing of unvalid mac addresses
[x] Create generic methodSee conversation belowassertViolation()inConstraintValidatorTestCase.phpto test that unvalid values do throw a violation.If this PR is accepted, I'll try to continue this work on other validators. I believe testing empty string and null values is important to ensure no BC occurs, for example.