Skip to content

[WebLink] Hint that prerender is deprecated #60431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2025

Conversation

dunglas
Copy link
Member

@dunglas dunglas commented May 15, 2025

Q A
Branch? 6.4
Bug fix? no
New feature? no
Deprecations? no
Issues n/a
License MIT

prerender has been deprecated. Add a hint in the PHPDoc not to use it.

I decided not to deprecate the constant and the function itself because even if the keyword is deprecated in the web platform, it can be useful.

@chalasr
Copy link
Member

chalasr commented May 15, 2025

Where can it be useful? Asking because if it's no longer useful in web context maybe it's no longer needed in weblink?

@dunglas
Copy link
Member Author

dunglas commented May 15, 2025

It's deprecated but still supported by Chrome-based browsers (Firefox and Safari never implemented this and don't support speculation rules either). No need to break working apps for now.

@nicolas-grekas
Copy link
Member

Thank you @dunglas.

@nicolas-grekas nicolas-grekas merged commit 255d35f into symfony:6.4 May 16, 2025
10 of 11 checks passed
OskarStark added a commit to symfony/symfony-docs that referenced this pull request May 16, 2025
This PR was merged into the 6.4 branch.

Discussion
----------

[WebLink] Hint that `prerender` is deprecated

Companion PR of symfony/symfony#60431

Commits
-------

c32e885 [WebLink] Hint that prerender is deprecated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants