Skip to content

[FrameworkBundle] Fix declaring field-attr tags in xml config files #60439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2025

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 7.2
Bug fix? yes
New feature? no
Deprecations? no
Issues -
License MIT

@carsonbot carsonbot added this to the 7.2 milestone May 16, 2025
@nicolas-grekas nicolas-grekas changed the title [FramewokrkBundle] Fix declaring fiel-attr tags in xml config files [FrameworkBundle] Fix declaring fiel-attr tags in xml config files May 16, 2025
@OskarStark OskarStark changed the title [FrameworkBundle] Fix declaring fiel-attr tags in xml config files [FrameworkBundle] Fix declaring field-attr tags in xml config files May 16, 2025
@stof
Copy link
Member

stof commented May 16, 2025

Could we add some tests covering both the usage with a single field-attr element and with multiple ones, to ensure that both cases works, as it does not use the usual fixXmlConfig() call converting the XML singular name to the plural name used in formats passing an array directly ? I'm still not convinced it works fine.
those tests should be added in FrameworkExtensionTestCase with the fixtures in the 3 formats ensuring consistent compat

@nicolas-grekas
Copy link
Member Author

Test case added (I did some cleanup also)

@nicolas-grekas nicolas-grekas merged commit d7e71fa into symfony:7.2 May 16, 2025
9 of 11 checks passed
@nicolas-grekas nicolas-grekas deleted the fwb-field-attr branch May 16, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants