Skip to content

[HttpKernel] MapEntityCollection concept #60450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: 7.3
Choose a base branch
from
Open

[HttpKernel] MapEntityCollection concept #60450

wants to merge 3 commits into from
+369 −0

Conversation

evgenij-vy
Copy link

@evgenij-vy evgenij-vy commented May 18, 2025 •
edited
Loading

Q A
Branch? 7.3
Bug fix? no
New feature? yes
Deprecations? no
Issues Feature. new attribute MapEntityCollection #60451
License MIT

Hi everybody. It seems that Symfony needed a smart resolver for entity collection.
It's concept, and if it is really interesting for the community, I'll continue working.
Example to use:

public function __invoke(
        #[MapEntityCollection(
            class: SomeEntity::class,
            queryString: 'queryString',
            queryMapping: ['someQueryProperty' => 'someEntityProperty'],
            doctrineParameters: ['entityProperty' => 'someValue'],
            filters: [
                MyCustomFilter::class,
            ],
            defaultOrdering: ['id' => 'ASC']
        )]
        iterable $collectionEntity,
        #[MapQueryString]
        QueryStringObject $queryString,
    )
    {
    }

@carsonbot carsonbot added this to the 7.3 milestone May 18, 2025
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "7.3" but it seems your PR description refers to branch "7.3 for features".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@evgenij-vy evgenij-vy mentioned this pull request May 18, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Feature HttpKernel Status: Needs Review
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.
2 participants
@evgenij-vy @carsonbot