[Validator] Revert Slug constraint #60475
Merged
+0
−254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit reverts symfony#58542.
|
cc @raffaelecarelle, as the original author of the PR. If there is something we're overlooking or you see value in the constraint that I'm missing, please feel free to share it here so we can consider it. |
xabbuh
approved these changes
May 19, 2025
HypeMC
approved these changes
May 19, 2025
|
I think PR #59383 should be reverted too |
alexandre-daubois
approved these changes
May 19, 2025
|
Warning you must also update/amend the corresponding blogpost otherwise ppl will think its a fail of release no ? |
stof
approved these changes
May 19, 2025
derrabus
approved these changes
May 20, 2025
|
PR on 6.4 to remove the translations: #60486 |
|
Thank you @wouterj. |
fabpot
added a commit
that referenced
this pull request
May 20, 2025
This PR was merged into the 6.4 branch. Discussion ---------- Remove translations for slug validation error | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Issues | | License | MIT Related to #60475 Commits ------- 42eb1c0 Remove translations for slug validation error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After an internal discussion, I think it's best to revert the introduction of the
Slugconstraint:AsciiSluggeris doing, but a more common approach is to only allow lowercase characters.Regexconstraint, especially when using it'sregexoption to customize the pattern for slugs.Considering this, I believe it is always better for applications to be clear on what they allow in a slug using the
Regexconstraint.