[PhpUnitBridge] Clean up mocked features only when @group
is present
#60484
+119
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #60174 introduced a bug for tests that don't use the
@group
annotation but register mocks manually, e.g. insetUpBeforeClass
:testDate
passes, but after thatFinishedSubscriber
is triggered which cleans up the mock and causestestTime
to fail.I am not sure what to do about
BeforeTestMethodErroredSubscriber
since the test object is not available in that event. I think it's fine to leave it as is.cc @xabbuh