Skip to content

[Validator] Fix - Missing translations for Turkish (tr) #60488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

koyolgecen
Copy link

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #60473
License MIT

This PR improves the Turkish translation for the validation message:

"This value is not a valid Twig template."

The previous translation was:

Bu değer geçerli bir Twig şablonu değil.

It has been updated for clarity and consistency with other translations:

Bu değer geçerli bir Twig şablonu olarak kabul edilmiyor.

This aligns better with the tone used in other Turkish validation messages across the Symfony project.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot carsonbot changed the title Fix - Missing translations for Turkish (tr) [Validator] Fix - Missing translations for Turkish (tr) May 20, 2025
@nicolas-grekas
Copy link
Member

Thank you @koyolgecen.

@nicolas-grekas nicolas-grekas merged commit 6d6e62e into symfony:6.4 May 20, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants