[PhpUnitBridge] Fix cleaning up mocked features with attributes #60500
+37
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HypeMC
commented
May 21, 2025
| @@ -50,35 +52,51 @@ public function bootstrap(Configuration $configuration, Facade $facade, Paramete | |||
|
|
|||
| $facade->registerSubscriber(new RegisterClockMockSubscriber($reader)); | |||
| $facade->registerSubscriber(new EnableClockMockSubscriber($reader)); | |||
| $facade->registerSubscriber(new class implements ErroredSubscriber { | |||
| $facade->registerSubscriber(new class($reader) implements ErroredSubscriber { | |||
| public function __construct(private AttributeReader $reader) | |||
There was a problem hiding this comment.
The reason I wanted to use the same instance of the reader was to leverage its internal cache. Perhaps moving the disableClockMock, disableDnsMock, and hasGroup methods to an abstract subscriber class would be better?
xabbuh
reviewed
May 22, 2025
xabbuh
approved these changes
May 22, 2025
|
looking at the CI failure we should probably also exclude the |
990d750 to
62da782
Compare
|
@xabbuh Don't know why I didn't do that from the start: https://github.com/symfony/symfony/compare/990d750552cd0e84af2d55076805a35ac99ea615..62da782fd3941e75bf150a52eebb6935623ad814 |
fabpot
approved these changes
May 24, 2025
|
Thank you @HypeMC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes usage of the attributes introduced in #59384 to reflect changes made in #60484.