[Runtime] Automatically use FrankenPHP runner when its worker mode is detected #60503
+203
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41b4f54 to
5a1bd6e
Compare
stof
reviewed
May 21, 2025
5a1bd6e to
1be5a66
Compare
1be5a66 to
f7b1310
Compare
dunglas
requested changes
May 22, 2025
Comment on lines
42
to
44
| if (\extension_loaded('xdebug') && \function_exists('xdebug_connect_to_client')) { | ||
| xdebug_connect_to_client(); | ||
| } |
There was a problem hiding this comment.
For the record, this feature is currently broken in Xdebug. We're investigating what's going on. It doesn't hurt to keep this code anyway.
f7b1310 to
fbf64c4
Compare
5eac909 to
5ce19ae
Compare
|
I'm having a look at the followup PR. Status: Needs Review |
src/Symfony/Component/Runtime/Tests/FrankenPhpWorkerRunnerTest.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
approved these changes
May 30, 2025
5ce19ae to
b81d09d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, to use FrankenPHP worker mode, you have to install the
runtime/frankenphp-symfonypackage and set theAPP_RUNTIMEenv var to the correct FQCN.@dunglas and I would like to move the runtime and the runner classes to the Symfony core now that The PHP Foundation officially supports FrakenPHP.
This PR adds FrankenPHP worker mode detection and registers the correct runner to use it. This specific runner is only used when using the worker mode. When using FrankenPHP in classic mode,
HttpKernelRunneris still used.The DX would be greatly improved, given that it works out of the box with this PR.
Classes and tests are coming from this repo with a few tweaks to stick to Symfony CS.