[WebProfilerBundle] display profiler url in logs #60505
Open
+214
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
reviewed
May 21, 2025
| @@ -4,6 +4,8 @@ CHANGELOG | |||
| 7.3 | |||
| --- | |||
|
|
|||
| * Display profiler URL in logs | |||
There was a problem hiding this comment.
We are feature freeze for 7.3, hopefully this feature will be for 7.4. You can add the 7.4 title.
| return; | ||
| } | ||
|
|
||
| $this->logger->debug(\sprintf('See profiler at %s', $this->urlGenerator->generate('_profiler', ['token' => $response->headers->get('X-Debug-Token')], UrlGeneratorInterface::ABSOLUTE_URL))); |
There was a problem hiding this comment.
The logger should do the interpolation. Does it work like this?
Suggested change
| $this->logger->debug(\sprintf('See profiler at %s', $this->urlGenerator->generate('_profiler', ['token' => $response->headers->get('X-Debug-Token')], UrlGeneratorInterface::ABSOLUTE_URL))); | |
| $this->logger->debug('See profiler at {profiler_url}', ['profiler_url' => $this->urlGenerator->generate('_profiler', ['token' => $response->headers->get('X-Debug-Token')], UrlGeneratorInterface::ABSOLUTE_URL)]); |
There was a problem hiding this comment.
why not use directly X-Debug-Token-Link header?
stof
reviewed
May 21, 2025
src/Symfony/Bundle/WebProfilerBundle/EventListener/ProfilerLinkLogListener.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/WebProfilerBundle/EventListener/ProfilerLinkLogListener.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/WebProfilerBundle/EventListener/ProfilerLinkLogListener.php
Outdated
Show resolved
Hide resolved
…kLogListener.php Co-authored-by: Christophe Coevoet <stof@notk.org>
|
Cool thanks for digging this idea 💡;)
Please no! That'd ruin the DX improvement this provides! |
94noni
reviewed
May 21, 2025
| public static function getSubscribedEvents(): array | ||
| { | ||
| return [ | ||
| KernelEvents::RESPONSE => ['onKernelResponse', -2048], |
There was a problem hiding this comment.
perhaps unrelated, but does the console command terminate event can also be hooked here ?
so both web/cli have this log ?
edit: its done already when profiling cli output, dont know if relevant for log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add the display of the profiler URL in the log as follows:
Thank you @nicolas-grekas for this idea.