[Lock] Better key naming when possible #60526
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use plain text for key name when they are short enough. It helps to understand where inserted locks come from when looking at the database.
|
I'm not sure how to test this change, any feedback/tips are welcome! |
OskarStark
reviewed
May 24, 2025
| @@ -48,8 +48,12 @@ private function init(array $options, float $gcProbability, int $initialTtl): vo | |||
| /** | |||
| * Returns a hashed version of the key. | |||
|
This creates collisions for keys, as a long key is not considered the same resource than its hash. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use plain text for key names when they are short enough.
It helps to understand where inserted locks come from when looking at the database.
See #57906 for examples of how the locks look like in the database.