Skip to content

[JsonStreamer] Remove nikic/php-parser dependency #60544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025

Conversation

mtarld
Copy link
Contributor

@mtarld mtarld commented May 26, 2025

Q A
Branch? 7.4
Bug fix? no
New feature? yes
Deprecations? no
Issues
License MIT

Remove nikic/php-parser dependency, and generate PHP code with strings.

/cc @nicolas-grekas

@carsonbot

This comment was marked as off-topic.

@OskarStark OskarStark changed the title [JsonStreamer] Remove "nikic/php-parser" dependency [JsonStreamer] Remove nikic/php-parser dependency May 26, 2025
@mtarld mtarld force-pushed the feat/json-streamer-remove-php-parser branch from d39189e to 89a3011 Compare May 26, 2025 07:19
@mtarld mtarld force-pushed the feat/json-streamer-remove-php-parser branch from 89a3011 to e1f2d33 Compare May 26, 2025 13:17
@mtarld mtarld requested a review from soyuka May 26, 2025 13:18
@mtarld mtarld force-pushed the feat/json-streamer-remove-php-parser branch from e1f2d33 to e5930b3 Compare May 26, 2025 13:29
@fabpot fabpot modified the milestones: 7.3, 7.4 May 26, 2025
@fabpot
Copy link
Member

fabpot commented May 29, 2025

Thank you @mtarld.

@fabpot fabpot merged commit c038498 into symfony:7.4 May 29, 2025
11 checks passed
@mtarld mtarld deleted the feat/json-streamer-remove-php-parser branch May 29, 2025 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants