Skip to content

[AssetMapper] add "full" type for packages to download all content #60545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 7.4
Choose a base branch
from

Conversation

eltharin
Copy link
Contributor

@eltharin eltharin commented May 26, 2025

Q A
Branch? 7.4
Bug fix? no
New feature? yes
Issues Fix ##59791
License MIT

This PR allow AssetMApper to deal with "no modules" libraries,
When we want to require a JS/CSS lib witch doen't have js module, we must import all files to download them.
But in a furthurer version, if one file is added or removed we can skip it.

With the new type "full", Assetmapper can read package contents files and download all of them.

  • create tests
  • Add documentation
  • Add flex change for importmap require from bundle

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "7.3" but it seems your PR description refers to branch "7.4".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@eltharin eltharin changed the title add "full" type for packages to download all content [AssetMapper] add "full" type for packages to download all content May 26, 2025
@eltharin eltharin force-pushed the assetmapper_ad_full_type branch from 5403809 to 5a74e2c Compare May 26, 2025 18:13
@fabpot fabpot modified the milestones: 7.3, 7.4 May 26, 2025
@eltharin eltharin force-pushed the assetmapper_ad_full_type branch from 5a74e2c to 2efdbb1 Compare May 26, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants