[Translation] Add intl-icu fallback for MessageCatalogue metadata #60549
+37
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b037768 to
0b5ebdb
Compare
OskarStark
reviewed
May 26, 2025
src/Symfony/Component/Translation/Tests/Catalogue/MetadataTest.php
Outdated
Show resolved
Hide resolved
|
Congrats @pontus-mp on your 1st contribution here! In order to propagate properply the fix, could you update your PR to target the 6.4 branch? Thank you |
ac97d5e to
456e98c
Compare
Sure! Does everything look correct now? |
welcoMattic
approved these changes
May 28, 2025
yceruto
reviewed
May 28, 2025
fabpot
approved these changes
May 29, 2025
|
Thank you @pontus-mp. |
This was referenced May 29, 2025
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added domain fallback for metadata, which should match the behavior used for fetching messages.