[Security] do not construct Vote instances inside vote() #60550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandre-daubois
approved these changes
May 26, 2025
nicolas-grekas
approved these changes
May 26, 2025
e908f8c to
3171209
Compare
The so constructed objects will never be seen from the outside. Thus, adding reasons to them doesn't have an effect.
mtarld
approved these changes
May 26, 2025
HypeMC
approved these changes
May 26, 2025
|
Thank you @xabbuh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The so constructed objects will never be seen from the outside. Thus, adding reasons to them doesn't have an effect.